logstf: Scrub IPs from logs + use HTTPS

[Arie]

Due to a recent incident, not directly related to logs.tf, I realized it could be nice to make these two small changes to the logs.tf uploader:

• Redact IP addresses before uploading (mask last two octets)
• Add cvar logstf_https to upload over HTTPS (default off)

[F2]

I think a previous "upload extension" (SteamTools) didn't support https, and that's why we used http. But we don't use that anymore, and I assume both SteamWorks and cURL support https.

How about we always use https with no http fallback?

[Arie]

Yeah I'm all for enabling https by default, both curl and steamworks support it. I didn't enable it by default only because the curl extension might be too old for the logs.tf TLS version/crypto or a missing CA bundle. But for that second one, cert checking/verification is explicitly disabled on the curl path of the anyhttp functions anyway.

[F2]

Made a few minor updates:

• Upped the size of ipPattern from 128 to 256 because your regex pattern was more than 128 characters which failed the regex compilation during startup.
• Prefer [0-9] over \d because at least in some regex languages \d can be other digit characters than the ones in [0-9]. I am not sure if that is the case in SourceMod, but no need to risk it.
• Always uses HTTPS now.
• I did some benchmarking to see if the regex had any negative effects, but it seems fine.

Let me know if you have any concerns before we complete the PR.

[Arie]

Sorry man, I must have messed up checking my latest regex, thought I did judging by git timestamps and my fork timestamp but I guess I didn't do it correctly.

Looks good to me for shipping.

[F2]

No worries! 😄 Your code changes were very robust so it didn't actually break anything, other than the IP scrubbing being skipped.

I tested that HTTPS upload works with both SteamWorks and curl on my machine, so we're good to go.