Deduplicate parseJSON row helper between extensions v1 and v2 - #167
Merged
Conversation
Both database.ts files defined an identical fallback-safe JSON parser for reading TEXT columns; moved it to src/lib/json.ts and re-exported it from each service's interfaces.ts, matching how sortReleasesDescending is already shared the same way.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
api | 1fd7193 | Commit Preview URL Branch Preview URL |
Jul 30 2026, 05:04 AM |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 5 files
Auto-approved: Refactor that deduplicates an identical helper function across two extensions services without changing behavior.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/services/extensions/v1/database.tsandv2/extensions-database.tseach defined an identical fallback-safe JSON parser for reading TEXT columns (releases/license/sourceetc.). This predates the Drizzle migration in Migrate database operations to Drizzle ORM and clean up scripts #166, noted there as a minor pre-existing nit.src/lib/json.tsand re-exported from each service'sinterfaces.ts, matching the existing pattern forsortReleasesDescending.