Require fresh GitHub organization evidence - #171
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
api | 65a7172 | Commit Preview URL Branch Preview URL |
Jul 31 2026, 08:27 AM |
admdly
marked this pull request as ready for review
July 31, 2026 08:05
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
Author
Follow-up: malformed expiry validationValidated the reported issue. Before the fix, the new regression using Fix in
|
Contributor
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Auto-approved: Adds expiry check to GitHub org membership evidence, requiring future RFC3339 timestamp. Fixes stale data reuse; bounded and clearly beneficial.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require a still-valid central-auth expiry before using stored GitHub organization memberships for developer ownership verification.
Root cause
The API previously treated any parseable
users.github_orgsJSON as current evidence. That allowed a copied organization list to remain usable after the auth service could no longer vouch for its freshness.Changes
userstable definition withgithub_orgs_expires_at.github_loginindependent so username verification continues to work.Historical
developers.github_org_verifiedrows are not automatically expired by this change; only new verification and existing re-verification paths use fresh organization evidence.