Compund selection fix#98
Open
krish-vj wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a bug in the compound selector: after selecting some compounds, when we open the compound selector again to change our selections, if we modify them (removing some old compounds and adding some new ones) but click Cancel instead of Add, reopening the compound selector makes it appear completely blank.
This PR fixes that.
Technical Details
Wiped State on Cancel: Previously, the cancel() method explicitly cleared the global compound list and emptied the UI table (self.tableWidget.setRowCount(0)). We updated cancel() to only dismiss the dialog (self.reject()) without deleting data.
UI Reversion: Added showEvent and sync_state to rebuild the selector's checkboxes using the saved global state every time the window is shown, discarding any aborted edits.
Deselection Support: Updated accept() to fully replace the global list with the current selections, allowing users to remove compounds.
Window Flags: Removed the buggy question mark (context help) button from the title bar by clearing the Qt.WindowContextHelpButtonHint flag.