Skip to content

NUClearNet 2 (protocol 0x03) - #29

Open
TrentHouliston wants to merge 21 commits into
mainfrom
houliston/nuclearnet-v2
Open

NUClearNet 2 (protocol 0x03)#29
TrentHouliston wants to merge 21 commits into
mainfrom
houliston/nuclearnet-v2

Sync nuclear subtree from NUClear@92711931

7f98a53
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Aug 14, 2026 in 2m 10s

Quality Gate failed

Failed conditions
10 Security Hotspots
E Reliability Rating on New Code (required ≥ A)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 497 in src/nuclear/src/dsl/word/UDP.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "::" to access "ntohl". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOoYS3uyRsdjYRih&open=AZ6MEOoYS3uyRsdjYRih&pullRequest=29

Check failure on line 158 in src/NetworkBinding.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ7T6VecDC12tAEKrSbP&open=AZ7T6VecDC12tAEKrSbP&pullRequest=29

Check warning on line 729 in src/nuclear/src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "reinterpret_cast" with a safer operation. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOurS3uyRsdjYRkG&open=AZ6MEOurS3uyRsdjYRkG&pullRequest=29

Check warning on line 78 in src/nuclear/src/util/network/sock_t.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "::" to access "ntohs". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOv_S3uyRsdjYRlP&open=AZ6MEOv_S3uyRsdjYRlP&pullRequest=29

Check warning on line 41 in src/nuclear/tests/tests/nuclearnet/Routing.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "::" to access "htons". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEO7BS3uyRsdjYRnt&open=AZ6MEO7BS3uyRsdjYRnt&pullRequest=29

Check warning on line 64 in src/nuclear/tests/tests/dsl/IdleSync.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid explicitly specifying the template arguments by relying on the class template argument deduction. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEO4rS3uyRsdjYRmg&open=AZ6MEO4rS3uyRsdjYRmg&pullRequest=29

Check warning on line 276 in src/nuclear/src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "::" to access "htonl". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOurS3uyRsdjYRj5&open=AZ6MEOurS3uyRsdjYRj5&pullRequest=29

Check failure on line 200 in src/nuclear/tests/tests/nuclearnet/ProcessPacket.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEO6WS3uyRsdjYRm2&open=AZ6MEO6WS3uyRsdjYRm2&pullRequest=29

Check warning on line 29 in src/nuclear/src/nuclearnet/PacketDeduplicator.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Concatenate this namespace with the nested one. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOt4S3uyRsdjYRja&open=AZ6MEOt4S3uyRsdjYRja&pullRequest=29

Check warning on line 43 in src/nuclear/src/nuclearnet/Log.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid explicitly specifying the template arguments by relying on the class template argument deduction. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6ManXUQFLKRviDQOll&open=AZ6ManXUQFLKRviDQOll&pullRequest=29

Check warning on line 81 in src/nuclear/src/nuclearnet/Routing.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "std::lock_guard" with "std::scoped_lock" 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOu8S3uyRsdjYRkn&open=AZ6MEOu8S3uyRsdjYRkn&pullRequest=29

Check failure on line 141 in src/nuclear/src/extension/ChronoController.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'std::memory_order::seq_cst' (or remove this argument to use its default value) to ensure sequential consistency. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOzWS3uyRsdjYRl4&open=AZ6MEOzWS3uyRsdjYRl4&pullRequest=29

Check warning on line 42 in src/nuclear/src/extension/trace/protobuf.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "enable_if" with a language construct (i.e. use an abbreviate function template, a "requires" clause, or an "if constexpr"). 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOzAS3uyRsdjYRlu&open=AZ6MEOzAS3uyRsdjYRlu&pullRequest=29

Check warning on line 429 in src/NetworkBinding.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch a more specific exception instead of a generic one. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEO_eS3uyRsdjYRpG&open=AZ6MEO_eS3uyRsdjYRpG&pullRequest=29

Check warning on line 46 in src/nuclear/tests/tests/nuclearnet/Discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "::" to access "htonl". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEO6gS3uyRsdjYRnH&open=AZ6MEO6gS3uyRsdjYRnH&pullRequest=29

Check warning on line 76 in src/nuclear/src/nuclearnet/Routing.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "std::lock_guard" with "std::scoped_lock" 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOu8S3uyRsdjYRkl&open=AZ6MEOu8S3uyRsdjYRkl&pullRequest=29

Check warning on line 79 in src/nuclear/tests/test_util/has_multicast.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "::" to access "ntohs". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEO9AS3uyRsdjYRol&open=AZ6MEO9AS3uyRsdjYRol&pullRequest=29

Check warning on line 33 in src/nuclear/.github/workflows/linting.yaml

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure that using clear-text protocols is safe here. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ_91d13rIcTy-_n_2Ua&open=AZ_91d13rIcTy-_n_2Ua&pullRequest=29

Check warning on line 40 in src/nuclear/src/util/string_join.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a reference-to-const. The current type of "out" is "class std::basic_stringstream<char> &". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOw5S3uyRsdjYRlh&open=AZ6MEOw5S3uyRsdjYRlh&pullRequest=29

Check warning on line 441 in src/nuclear/src/nuclearnet/Discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "std::lock_guard" with "std::scoped_lock" 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOtGS3uyRsdjYRjC&open=AZ6MEOtGS3uyRsdjYRjC&pullRequest=29

Check failure on line 348 in src/nuclear/tests/tests/nuclearnet/ProcessPacket.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ_-kle6G_d3VrJ8LekU&open=AZ_-kle6G_d3VrJ8LekU&pullRequest=29

Check warning on line 202 in src/nuclear/src/LogLevel.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this const reference to "std::string" by a "std::string_view". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEO0hS3uyRsdjYRmJ&open=AZ6MEO0hS3uyRsdjYRmJ&pullRequest=29

Check failure on line 351 in src/nuclear/tests/tests/nuclearnet/Discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEO6gS3uyRsdjYRnS&open=AZ6MEO6gS3uyRsdjYRnS&pullRequest=29

Check warning on line 902 in src/nuclear/src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::byte" for byte-oriented data manipulation. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEOurS3uyRsdjYRkR&open=AZ6MEOurS3uyRsdjYRkR&pullRequest=29

Check warning on line 202 in src/nuclear/tests/test_util/has_multicast.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure using this hardcoded IP address is safe here. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClearNet.js&issues=AZ6MEO9AS3uyRsdjYRo1&open=AZ6MEO9AS3uyRsdjYRo1&pullRequest=29
View more details on SonarQubeCloud