Conversation
…ring) (FasterXML#781) `_streamReadConstraints()` returned `StreamReadConstraints.defaults()`, so a `maxNumberLength` configured on the `SmileFactory` was ignored by the number-length guard in `writeNumber(String)`. Use the factory's constraints via `IOContext` instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #781.
SmileGenerator._streamReadConstraints()— used by_writeIntegralNumber()/_writeDecimalNumber()to guardwriteNumber(String)against over-long number Strings — returnedStreamReadConstraints.defaults(), so amaxNumberLengthconfigured on theSmileFactorywas ignored on the write path (lower limits not enforced, higher limits spuriously rejected).Now returns
_ioContext.streamReadConstraints(), i.e. the factory's configured instance.Adds
SmileGeneratorNumbersTest.testNumbersAsStringLengthLimitcovering both the integral and decimal paths, plus a round-trip at the limit.🤖 Generated with Claude Code