Support StreamReadConstraints.maxDocumentLength in ProtobufParser - #784
Open
pjfanning wants to merge 1 commit into
Open
Support StreamReadConstraints.maxDocumentLength in ProtobufParser#784pjfanning wants to merge 1 commit into
StreamReadConstraints.maxDocumentLength in ProtobufParser#784pjfanning wants to merge 1 commit into
Conversation
…sterXML#783) Validate document length when reloading the input buffer for streaming input (loadMore() / _loadToHaveAtLeast()), and up front for fixed byte[] input in ProtobufFactory, matching what CBOR and Smile already do. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #783.
ProtobufParserignoredStreamReadConstraints.maxDocumentLength. This adds the same checks CBOR and Smile have:loadMore()/_loadToHaveAtLeast():validateDocumentLength(_currInputProcessed)after advancing the processed-bytes counter (streaming input)ProtobufFactory._createParser(..., byte[], int, int):validateDocumentLength(len)up front (fixed-buffer input, as per [core#1548])Adds
dos/LongDocumentProtobufReadTestcovering both input modes, plus an unconstrained control. Verified the test fails without the parser/factory change.🤖 Generated with Claude Code