Conversation
…Avro parser (FasterXML#785) - AvroParserImpl.nextToken() / nextNameMatch(): route through _nullSafeUpdateToken() so tokens are counted - JacksonAvroParserImpl: validate document length on buffer reload - AvroFactory: validate document length up front for byte[] input - ApacheAvroParserImpl: wrap the InputStream in a byte-counting stream (only when maxDocumentLength is set), since the Apache BinaryDecoder does its own buffering Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #785.
maxTokenCount:AvroParserImpl.nextToken()andnextNameMatch()now go through_nullSafeUpdateToken()instead of assigning_currTokendirectly, so tokens are counted and the limit enforced (thenextName()variants already did this).maxDocumentLength, matching CBOR/Smile:JacksonAvroParserImpl._loadMore()/_loadToHaveAtLeast():validateDocumentLength(_currInputProcessed)on buffer reloadAvroFactory._createParser(..., byte[], int, int):validateDocumentLength(len)up front (both decoders)ApacheAvroParserImpl(streaming): the ApacheBinaryDecoderreads from theInputStreamitself, so the stream is wrapped in a small byte-countingFilterInputStreamthat validates as bytes are pulled. Only wrapped whenhasMaxDocumentLength(), so no overhead by default.Tests:
constraints/TokenCountAvroReadTestandconstraints/LongDocumentAvroReadTest, each covering Jackson and Apache decoders ×byte[]andInputStreaminput. Both fail without the main-code changes.Note:
interop/**tests (AvroAliasTest,AvroEncodeTest, ...) fail locally withStackOverflowErrorinApacheAvroInteropUtilReflectData schema generation — pre-existing on clean3.x, unrelated to this PR.🤖 Generated with Claude Code