Conversation
…elds from the symbol_registry
… of symbols for the processing of logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dsROCrate 0.2.1
Bug Fixes
as.data.frame.safe_call()(two files each defined this S3 method with different output columns; only one could ever take effect, silently). Thesafe-call.Rversion — timestamp, user, r_cmd, fx, args, session, profile — is now the sole implementation.print.safe_symbol()referencing stalecolumn/parentfields left over from before the 0.2.0 symbol-model refactor; it now correctly displays the symbol'sasset,expr, andsession(guarding on bothNULLandNA, since these fields default toNA_character_).as.data.frame.symbol_registry(), which previously iterated over the columns of the underlying tibble instead of its rows (vialapply()on a data frame), causing it to error whenever called on a non-empty registry. It also referenced non-existentparent/columnfields. The method now simply returnsx$symbolscoerced to a data frame, which already carries the correct columns.register_symbol()erroring on a brand-new, empty registry (the very first symbol registered in any session): the emptiness check comparednrow()of a plain, pre-tibblelist()before checkinglength(), producing a zero-length logical passed to||. Thelength()check is now evaluated first, so it short-circuits correctly.as.data.frame.safe_call()'sargscolumn having an unstable name and shape depending on how many arguments the underlying call had (a single-argument call collapsed the column into one named after that argument, e.g.x; multiple arguments spread into several columns instead of one). The argument list is now wrapped withI(list(...))so it always appears as a single, reliably-namedargslist-column.safe_call()/as.data.frame.safe_call(),print.safe_symbol(), andregister_symbol()/as.data.frame.symbol_registry(), none of which previously had any test coverage.Internal Changes
has_symbol()/has_symbol.symbol_registry()(and its S3 export) andsafe_symbol_reference()/new_safe_symbol_reference(), none of which were called anywhere in the package.safe_symbol()andprint.safe_call().@param,@returns,@keywords internal,@noRd) and explanatory comments to the internal symbol-tracking functions introduced in 0.2.0 (safe_call(),safe_symbol(),safe_reference(),symbol_registry(), and their supporting utilities), with no change in behaviour.WORDLIST.