feat(storage): add batch piece deletion - #898
Open
hugomrdias wants to merge 3 commits into
Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
synapse-dev | f083d5a | Commit Preview URL Branch Preview URL |
Aug 06 2026, 12:06 PM |
rvagg
reviewed
Jul 23, 2026
rvagg
reviewed
Jul 23, 2026
rvagg
reviewed
Jul 23, 2026
rvagg
reviewed
Jul 23, 2026
hugomrdias
force-pushed
the
hugomrdias/551-batch-piece-deletions
branch
from
August 6, 2026 11:56
b35b371 to
f083d5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deletePiecesandschedulePieceDeletionsoperations to synapse-coreStorageContext.deletePieces()while preserving the existing singular API as a compatibility wrapperWhy
The EIP-712
SchedulePieceRemovalsauthorization already supports multiple piece IDs, but the SDK only submitted one piece at a time. Curio PR filecoin-project/curio#1309 added a compatiblepieceIdsrequest field, allowing one authorization and one on-chain transaction to schedule up to 500 removals.Closes #551.
Developer impact
Consumers can now call:
The existing
deletePiece()andschedulePieceDeletion()APIs remain available and delegate to the plural implementations.Validation
pnpm run buildpnpm testpnpm run lint:fixinpackages/synapse-coreandpackages/synapse-sdkThe root lint command still reports pre-existing accessibility errors in documentation SVG assets; no documentation assets are changed by this PR.