fix(synapse-core): accept deployment contracts metadata - #907
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
synapse-dev | 7a6fba6 | Commit Preview URL Branch Preview URL |
Aug 05 2026, 11:03 AM |
rjan90
marked this pull request as ready for review
August 5, 2026 11:07
hugomrdias
approved these changes
Aug 6, 2026
github-project-automation
Bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FOC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Allow the strict per-network deployment schema in
packages/synapse-core/wagmi.config.tsto accept the optional top-levelcontractsmetadata map produced byfilecoin-servicesdeployment tooling.The metadata remains opaque because ABI generation does not consume it. Existing required address validation and strict rejection of other unknown top-level keys remain unchanged.
Why
The
v1.3.1Update Synapse SDK workflow failed before it could generate ABIs or open its update PR:filecoin-services/service_contracts/deployments.jsonnow includes deployment-planning metadata undercontractsfor both networks. Synapse only needs the legacy address fields from that document, but its strict schema must recognize the additional documented key.Tracks the Synapse gate in filecoin-services#561.