chore: update several packages, including firebase to v12. - #123
KingDarBoja wants to merge 3 commits into
Conversation
- Switch ESLint to Flat Config. - Peer dependencies updated to support only firebase v12 and above due to the renaming of firebase/vertexai to firebase/ai.
Summary of ChangesHello @KingDarBoja, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant dependency upgrade, primarily moving to Firebase version 12, which required adapting to API changes like the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request brings several important updates, including upgrading to Firebase v12, switching to ESLint's Flat Config, and adding support for firebase/ai. The dependency updates and configuration changes are well-executed. I've found a few areas for improvement, mainly around consistent use of modern RxJS APIs and improving type safety in a couple of spots. There's also a minor typo in a test file. Overall, this is a solid update that modernizes the project's tooling and dependencies.
|
@jamesdaniels any updates on this? |
|
Hi @davideast. Sorry for the ping, but is there someone who can take a look at this? |
|
Hey @armando-navarro, do you want me to split the changes into smaller PRs (ESLint, rollup, etc) if applies? |
|
@KingDarBoja I'm actively investigating this. But yes, this needs to be split up for a number of reasons. Please await my report. |
|
Hey @KingDarBoja, thanks for the ping, and sorry for the long wait. Yes, please split it. Also,
Two things to fix regardless of how you split the PRI checked out the branch and ran what CI runs.
How I would split thingsIn this order:
Separate reformatting into its own PR if you want to submit themMost of your changes are reformatting, so re-authoring on fresh branches will be easier than cherry-picking. Please keep formatting-only changes out of the code PRs ( One correction: #93 is about Thanks again for pushing on this. |
|
Okay, I have made a new branch with a PR for the first step (type fixes): #154 |
Changes
This should fix #122 and probably #93 and #94 as I managed to provide correct typing fixes to that.
I started doing this after seeing issues like angular/angularfire#3666 due to firebase v12 renaming the vertexai thingy.