Skip to content

feat: add transactional journal semantics - #35

Merged
Freyskeyd merged 2 commits into
mainfrom
freyskeyd/che-2-design-and-implement-transactional-journal-semantics
Sep 11, 2026
Merged

Freyskeyd merged 2 commits into
mainfrom
freyskeyd/che-2-design-and-implement-transactional-journal-semantics

Conversation

@Freyskeyd

Copy link
Copy Markdown
Owner

Summary

Implements Linear issue CHE-2 with a runtime-independent chekov-journal layer above chekov-core.

  • Adds read-your-writes overlays and nested affine checkpoints.
  • Merges committed child writes and discards reverted writes.
  • Retains observations from reverted scopes.
  • Coalesces repeated writes into final mutations.
  • Produces deterministic transition batches while sharing values through Arc.
  • Adds semantic coverage for nested commit/revert, tombstones, read propagation, coalescing, and deterministic output.

Verification

  • cargo test --workspace
  • cargo check --workspace
  • cargo fmt --all -- --check
  • cargo clippy -p chekov-journal --all-targets -- -D warnings

@linear-code

linear-code Bot commented Sep 8, 2026

Copy link
Copy Markdown

CHE-2

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Failed checkpoint operations consume indispensable tokens, leaving open frames impossible to close.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds a runtime-independent transactional journal layer over chekov-core.

Changes:

  • Implements nested checkpoints with commit/revert semantics.
  • Adds read tracking, write coalescing, tombstones, and deterministic transitions.
  • Adds semantic unit tests and workspace registration.
File summaries
File Description
crates/chekov-journal/src/lib.rs Implements journal behavior and tests.
crates/chekov-journal/Cargo.toml Defines the new crate.
Cargo.toml Registers workspace dependencies.
Cargo.lock Records the new package.
Review details
  • Files reviewed: 3/4 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread crates/chekov-journal/src/lib.rs Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The transition methods return a checkpoint error variant whose documented meaning does not match the failure condition.

Review details

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

crates/chekov-journal/src/lib.rs:78

  • NotTopCheckpoint is also returned by transition and into_transition when any checkpoint remains open, although those operations receive no checkpoint token and the documented condition is therefore false. This conflates an out-of-order close with an unfinished transaction for API consumers; add a distinct OpenCheckpoints variant (and broaden the enum-level documentation) for both transition paths.
  • Files reviewed: 3/4 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

Repository owner deleted a comment from chatgpt-codex-connector Bot Sep 9, 2026
Repository owner deleted a comment from chatgpt-codex-connector Bot Sep 9, 2026
Repository owner deleted a comment from chatgpt-codex-connector Bot Sep 9, 2026
@Freyskeyd
Freyskeyd force-pushed the freyskeyd/che-2-design-and-implement-transactional-journal-semantics branch from 7914260 to 0af849c Compare September 9, 2026 08:10
@Freyskeyd
Freyskeyd force-pushed the freyskeyd/che-2-design-and-implement-transactional-journal-semantics branch from 0af849c to 723b903 Compare September 9, 2026 08:10
Repository owner deleted a comment from chatgpt-codex-connector Bot Sep 9, 2026
@Freyskeyd

Copy link
Copy Markdown
Owner Author

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 723b9032c6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@Freyskeyd
Freyskeyd merged commit be6e34e into main Sep 11, 2026
18 checks passed
@Freyskeyd
Freyskeyd deleted the freyskeyd/che-2-design-and-implement-transactional-journal-semantics branch September 11, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants