fix: correct the effective stress calculation for thermoporomechanics - #3884
Merged
Conversation
frankfeifan
marked this pull request as ready for review
October 27, 2025 03:07
frankfeifan
requested review from
CusiniM,
Guotong-Ren,
castelletto1,
jhuang2601 and
rrsettgast
as code owners
October 27, 2025 03:07
Contributor
Author
|
An integrated test is added to verify the implementation: https://github.com/GEOS-DEV/GEOS/blob/deaa1bda781b98215e21a7671b55756f434a5604/inputFiles/thermoPoromechanics/ThermoDruckerPrager_1DCooling_smoke.xml The previous GEOS total stress calculation cannot match the analytical solution: With this fix, the analytical solution can be matched: |
paveltomin
removed request for
CusiniM,
Guotong-Ren,
matteofrigo5 and
paveltomin
January 26, 2026 16:21
…oPorousSolidTotalStress
…oPorousSolidTotalStress
…oPorousSolidTotalStress
…oPorousSolidTotalStress
jhuang2601
approved these changes
Aug 11, 2026
jhuang2601
left a comment
Contributor
There was a problem hiding this comment.
Great update, thanks!
jhuang2601
requested review from
bd713,
dkachuma and
herve-gross
as code owners
August 11, 2026 20:06
herve-gross
approved these changes
Aug 11, 2026
…oPorousSolidTotalStress
…oPorousSolidTotalStress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to correct the current GEOS effective stress calculation such that it is consistent with Terzaghi definition. Detailed explanations on the issue and this change can be seen in the file attached.
THMEffStress_GEOS.pdf
dTotalStress_dTemperatureinPorousSolidfor the thermal caseavgPlasticStraincalculation. (assumedavgPlasticStrainto be purely mechanical deformation).Another PR(s) needed to fix following items