Turn on hypredrive by default - #4071
Merged
Merged
Conversation
rrsettgast
marked this pull request as ready for review
June 1, 2026 14:05
rrsettgast
added
ci: run CUDA builds
Contributor
Author
|
Contributor
Author
|
@victorapm Pretty sure that hypredrive is the source of failure. I will split the TPL work to separate ADIOS and hypredrive modifications, and repurpose this PR to just look at ADIOS, and create a new PR for hypredrive. |
victorapm
requested review from
OmarDuran,
bd713 and
joshua-white
as code owners
August 1, 2026 04:18
victorapm
changed the title
victorapm
approved these changes
Aug 16, 2026
Contributor
|
@rrsettgast I figured out the remaining discrepancies between hypre and hypredrive and now CI is all green |
castelletto1
approved these changes
Aug 16, 2026
Contributor
|
Thanks all, Ready to merge! We're only missing one review from a code owner |
joshua-white
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns on hypredrive by default in GEOS
Note: we are not adding
adios2anymore in this branch, as suggested by its name