Skip to content

Apply Compose profiles to service selection - #28

Merged
GaTTGeng merged 2 commits into
masterfrom
codex/issue-12-profiles
Jul 31, 2026
Merged

Apply Compose profiles to service selection#28
GaTTGeng merged 2 commits into
masterfrom
codex/issue-12-profiles

Conversation

@GaTTGeng

Copy link
Copy Markdown
Owner

Summary

  • apply ComposeProjectContext.Profiles through a shared service selector
  • keep services without profiles enabled and include any service matching an active profile
  • allow explicitly named services to be selected even when their profile is inactive
  • cover context-based selection and explicit service selection with tests

Validation

  • dotnet build ComposeSharp.sln --configuration Release --no-restore
  • dotnet test ComposeSharp.sln --configuration Release --no-build --no-restore
  • dotnet pack ComposeSharp.sln --configuration Release --no-build --no-restore --output artifacts/packages
  • ./scripts/VerifyPackageReadme.ps1

@GaTTGeng
GaTTGeng marked this pull request as ready for review July 31, 2026 03:42
Copilot AI review requested due to automatic review settings July 31, 2026 03:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 55d664c8f5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ComposeSharp.Engine/ComposeService.cs Outdated
@GaTTGeng
GaTTGeng merged commit 9a9da55 into master Jul 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants