Add Physical Bus Wiring To GRCAN.CANdo As physical topology Section - #532
Draft
coderask wants to merge 3 commits into
Draft
Add Physical Bus Wiring To GRCAN.CANdo As physical topology Section#532coderask wants to merge 3 commits into
GRCAN.CANdo As physical topology Section#532coderask wants to merge 3 commits into
Conversation
Import the physical CAN bus topology (which nodes are physically wired to each bus) from GRCAN-Web's `can_topology.json` into a new hand-editable `physical topology:` top-level section in `GRCAN.CANdo`. CANdo is the authoritative source of truth; topology is enforced only in the web viewer, so no Perl parser consumes this section. Verified inert: all generated headers are byte-identical before and after the change. Reconciled against the authoritative `routing` section: added `HV DC-DC` and `LV DC-DC` to `Primary` (both transmit `DC-DC Status` there per routing, but were absent from the viewer's `can_topology.json`).
3 tasks
Contributor
|
Why have both physical topology and which item is on which bus? Is that redundant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Physical Bus Wiring In
GRCAN.CANdoProblem and Scope
GRCAN.CANdois the source of truth for CAN configuration, but the physical bus wiring — which nodes are actually wired to which CAN bus — lived only in GRCAN-Web's separatecan_topology.json, moved out of this repo in #521.Description
Adds a hand-editable
physical topologytop-level section toAutogen/CAN/Doc/GRCAN.CANdorecording which nodes are physically wired to each CAN bus (Primary,Data,Charger). Data imported from GRCAN-Web'scan_topology.json(Gaucho-Racing/GRCAN-Web, HEADf790c93).Kept as a separate top-level section rather than folded into
Bus IDso it stays easy to edit by hand. Reconciled withrouting: addedHV DC-DCandLV DC-DCtoPrimary— both transmitDC-DC Statusthere per the authoritative routing — which the imported viewer file omitted. The only routed-but-unlisted node remaining isDebugger, the intentional always-allowed exemption.Gotchas and Limitations
Record-only — no Perl parser consumes this section, so no generated headers change. Topology enforcement still lives only in the viewer. Buses omitted here (e.g. Testing) are treated as unrestricted. Device and bus names must stay in sync with the GR ID and Bus ID sections by hand.
Testing
Testing Details
All locally-runnable parsers (
Bus/CAN/GR/MSG) emit byte-identical output before and after this change.Larger Impact
Physical wiring now sits alongside the logical bus and routing definitions in the authoritative CANdo file, instead of only in the web viewer.
Additional Context and Ticket
Physical-wiring data originally moved to GRCAN-Web in #521. Follow-up: GRCAN-Web's
can_topology.jsonis now a duplicate and should later derive from CANdo rather than being a separate source.