Skip to content

fix(rendering): Prevent crash on null texture surface creation in Build_Textures #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −0
Open

fix(rendering): Prevent crash on null texture surface creation in Build_Textures #588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions Core/Libraries/Source/WWVegas/WW3D2/render2dsentence.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,8 +359,27 @@ Render2DSentenceClass::Build_Textures ()
// Create the new texture
//
TextureClass *new_texture = W3DNEW TextureClass (desc.Width, desc.Width, WW3D_FORMAT_A4R4G4B4, MIP_LEVELS_1);

//
// Validate that texture allocation succeeded
//
if (new_texture == nullptr) {
REF_PTR_RELEASE (curr_surface);
continue;
}

SurfaceClass *texture_surface = new_texture->Get_Surface_Level ();

//
// Validate that the texture surface is valid before using it
//
if (texture_surface == nullptr || !texture_surface->Is_Valid()) {
REF_PTR_RELEASE (texture_surface);
REF_PTR_RELEASE (new_texture);
REF_PTR_RELEASE (curr_surface);
continue;
}

new_texture->Get_Filter().Set_U_Addr_Mode(TextureFilterClass::TEXTURE_ADDRESS_CLAMP);
new_texture->Get_Filter().Set_V_Addr_Mode(TextureFilterClass::TEXTURE_ADDRESS_CLAMP);
new_texture->Get_Filter().Set_Min_Filter(TextureFilterClass::FILTER_TYPE_NONE);
Expand Down
Loading