fix: Prevent null dereference in AITNGuardOuterState update - #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a fatal crash (EXCEPTION_ACCESS_VIOLATION_READ) occurring in
AITNGuardOuterState::update().The root cause was identified as a null pointer dereference of
m_attackState. TheonEnter()method forAITNGuardOuterStatecan return early withSTATE_SUCCESSif the guard mode isGUARDMODE_GUARD_WITHOUT_PURSUITor if the nemesis object is null. In these scenarios,m_attackStateis never initialized, remainingnullptr.Subsequently, when
AITNGuardOuterState::update()is called, it attempts to accessm_attackState->getMachineGoalObject()without first checking ifm_attackStateis valid, leading to a crash.The fix introduces a null-check at the beginning of
AITNGuardOuterState::update(). Ifm_attackStateisnullptr, the method now safely returnsSTATE_SUCCESS, aligning its behavior with the early-exit conditions ofonEnter()and preventing the dereference of an uninitialized pointer.Fixes CLIENT-19W