Repository navigation
fix(launcher): forward gentle-shell mcp to pi's own mcp command - #2204
Conversation
pi dispatches mcp on argv[0], but mcp was missing from PI_SUBCOMMANDS, so the launcher injected -e ahead of it and pi treated 'mcp list' as a prompt. A separator after a pi subcommand is now kept, so 'mcp add <name> -- <cmd>' reaches pi verbatim. Closes #2140.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 4 files. (1 skipped: 1… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: forwarding the launcher’s mcpcommand to Pi’s MCP command.Linked Issues check Issue #2140requests a supported standalone workflow for MCP configuration. The launcher now recognizesmcpas a Pi subcommand and forwards it to Pi with the resolved home. The launcher preserves th…Out of Scope Changes check The changed launcher code implements MCP subcommand dispatch and separator forwarding. The generated runtime file mirrors the source change. The tests verify the new argument handling and help text. T…
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 4 files. (1 skipped: 1 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
…ng#2205, Gentleman-Programming#2207) before resolving the launcher import conflict # Conflicts: # bin/gentle-shell.mjs
1 participant
Closes #2140
Summary
gentle-shell mcp <command>now reaches Pi's ownmcpcommand against the resolved home, so standalone installs can add, list, log in to and log out of MCP servers.mcpwas missing fromPI_SUBCOMMANDS, so the launcher injected-e <package>ahead of it and Pi treatedmcp listas a prompt (it asked for an API key;mcp addwrote nothing).--that follows a pi subcommand is now kept, sogentle-shell mcp add <name> -- <command>reaches Pi verbatim. A leading--is still the launcher's own separator.Changes
lib/gentle-shell-launcher.ts(+ generatedruntime/gentle-shell-launcher.mjs)mcptoPI_SUBCOMMANDS; keep a separator after a pi subcommand; help texttests/gentle-shell-bin.test.tsmcp add <name> -- <cmd>;--helplistsmcptests/gentle-shell-launcher.test.tsdocs/readme-reference.mdTest plan
['-e', '<pkg>', 'mcp', 'add', 'demo', 'npx', ...](separator lost);--helphad nomcp.node --experimental-strip-types --test tests/gentle-shell-launcher.test.ts tests/gentle-shell-bin.test.ts: 374 pass, 0 fail.npm test: 6629 pass, 0 fail (unit, provider-contract, runtime-harness).node scripts/check-types.mjs: no regressions;pnpm run check:runtime-modules: runtime matches sources.HOME,GENTLE_SHELL_NO_AUTO_SETUP=1:gentle-shell mcp add demo -- echo hiwrote~/.gentle-shell/agent/mcp.json;gentle-shell mcp listlisted it.Summary by CodeRabbit
mcpcommand to pass commands through to Pi, including support for adding stdio and remote servers and listing configured servers.mcpexamples. Restart Gentle Shell to load newly configured servers.--when passing commands tomcp add, so command arguments are forwarded correctly.