perf: raise the default connection pool size from 5 to 100 - #90
Merged
Merged
Conversation
The default of 5 capped each client at 5 concurrent requests, so busy servers queued behind the pool. 100 matches httpx's default and stream-py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The default
SocketsHttpHandlercapped each client at 5 connections per server (MaxConnectionsPerServer = 5). The API is served over HTTP/1.1, so a 6th concurrent request queues for a free connection, and that wait counts against the request timeout.Solution
MaxConnsPerHostdefault from 5 to 100 inStreamOptionsandClientBuilder. Idle connections still close after 55s.MaxConnsPerHost = 5.How to verify
dotnet test tests --filter "FullyQualifiedName~ConnectionPoolTests|FullyQualifiedName~ClientBuilderTests"MaxConnectionsPerServerand theclient.initializedlog line at 100.