feat: [FEEDS-1965] add top_level_comment_count to feeds getActivity and getComments - #359
Merged
JimmyPettersson85 merged 4 commits intoSep 29, 2026
Merged
Conversation
Picks up API changes already on chat master before adding FEEDS-1965 fields in the next commit. No hand edits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Regenerated for FEEDS-1965: include_top_level_comment_count on getActivity/getComments, top_level_comment_count on both responses, and the always-present comment_count on GetCommentsResponse. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JimmyPettersson85
requested review from
oliverlaz and
szuperaz
as code owners
September 29, 2026 09:13
oliverlaz
approved these changes
Sep 29, 2026
szuperaz
approved these changes
Sep 29, 2026
JimmyPettersson85
deleted the
feature/feeds-1965-top-level-comment-count
branch
September 29, 2026 18:38
JimmyPettersson85
pushed a commit
that referenced
this pull request
Sep 29, 2026
🤖 I have created a release *beep* *boop* --- ## [0.8.9](v0.8.8...v0.8.9) (2026-09-29) ### Features * [FEEDS-1965] add top_level_comment_count to feeds getActivity and getComments ([#359](#359)) ([bf251c5](bf251c5)) * regenerate with the flat sendRequest response and no default JSON content type ([#357](#357)) ([9d50ab4](9d50ab4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://linear.app/stream/issue/FEEDS-1965
Summary
Regenerates the server SDK for the new read-time top-level comment count on the feeds backend:
feeds.getActivityrequestinclude_top_level_comment_count?: booleanActivityResponsetop_level_comment_count?: numberfeeds.getCommentsrequestinclude_top_level_comment_count?: booleanid_aroundrequest for deep links)GetCommentsResponsecomment_count: numberGetCommentsResponsetop_level_comment_count?: numbertop_level_comment_countcounts comments made directly on the activity (replies excluded), with the same active/not-deleted rules ascomment_count. It is not adjusted per viewer.Implementation notes
Two commits, so the feature diff is reviewable on its own:
chore: regenerate from the current chat OpenAPI spec: API changes already on chat master since the last regeneration, generated from the chat master spec. No feature changes.feat: add top_level_comment_count …: the actual change, 16 lines insrc/gen/feeds/FeedsApi.tsandsrc/gen/models/index.ts.Both generated with chat's
tools/openapi(generate-client --language ts, as ingenerate-openapi.sh) followed byyarn lint:gen; nothing undersrc/genis hand-edited.yarn buildandyarn lintpass. I ran the chat QA suite locally against this build (yarn-linked) using the typedfeeds.getActivity/feeds.getCommentsmethods against a backend built from the chat branch; it passed.Chat backend PR: branch
feature/feeds-1965-top-level-comment-countin GetStream/chat (the chat QA Makefile installs this branch by name).🤖 Generated with Claude Code