Conversation
Picks up poll auto-translation i18n fields (name_i18n/description_i18n on Poll, text_i18n on PollOption, answer_text_i18n on PollVote), plus other API additions accumulated since the last regeneration. Toolchain note: generate.sh's `uv run ruff ...` calls aren't frozen, so on an environment whose uv can't parse this lock's timestamp-cutoff field, uv silently re-resolves and picks up newer package versions (hit this locally: ruff 0.15.5 -> 0.16.8, which reformats the whole generated tree). Ran this regeneration with UV_FROZEN=1 to keep the pinned toolchain; worth adding to generate.sh itself.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Closing — reconsidering approach for backend SDK updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Summary
Regenerates the client from the current chat OpenAPI spec (
make openapioff chat master). Adds poll auto-translation i18n fields (chat CHA-5308, GetStream/chat#17029):PollResponseData.name_i18n/description_i18nPollOptionResponseData.text_i18nPollVoteResponseData.answer_text_i18nServer-owned, read-only fields (same
Optional[Dict[str, str]]shape/convention as the existing message-leveli18n) — no request types changed.The regen also picked up other spec drift accumulated since this SDK's last regeneration (feeds/video/moderation additions) — unrelated to the poll feature, just normal catch-up.
Note on style
The generator always emits
List[...]/Dict[...](fromtyping); a handful of poll-adjacent fields in the previously-committed file used modern lowercaselist[...]/dict[...]instead (pre-existing inconsistency, not something this PR introduces intentionally — the generator itself has no option for the modern style, so regenerating reverted those specific spots back to the file's dominant convention).Toolchain gotcha hit while regenerating
generate.sh'suv run ruff check/formatcalls aren't frozen. On auvinstall that can't parse this lockfile's timestamp-cutoff field, that silently re-resolves and grabs newer package versions instead of erroring — I hitruff 0.15.5 → 0.16.8, which reformats the entire generated tree into a much noisier diff. Ran this regeneration withUV_FROZEN=1to stay on the pinned lock; might be worth baking that intogenerate.shso it can't happen again.Test plan
UV_FROZEN=1 make lintUV_FROZEN=1 make typecheckUV_FROZEN=1 make test(476 passed, 1 skipped)make test-video/ integration suite (needs live API credentials, not run locally)