fix: [FEEDS-1966] Read the Java SDK version from its own jar - #109
Merged
Merged
Conversation
A root version.properties is also shipped by stream-chat-java, so the classloader could stamp X-Stream-Client with the other library's version. Co-authored-by: Cursor <cursoragent@cursor.com>
itsmeadi
changed the title
mogita
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stream-sdk-javaloadedversion.propertiesfrom the classpath root.stream-chat-javaships a file with that same name, and the classloader returns whichever jar comes first, so Feeds calls made by this SDK were stampedX-Stream-Client: stream-java-client-1.41.0.The version still comes from
gradle.properties, which release-please already bumps. The build now writes it toio/getstream/stream-sdk-java/version.properties, and the client reads that path.Checklist
./docs) has been updatedMade with Cursor