Skip to content

[FEEDS-1965] Backport top-level comment count onto 4.1.1 - #111

Open
itsmeadi wants to merge 3 commits into
release-4.1.1-feed-countsfrom
release-4.1.1-top-level-comment-count
Open

itsmeadi wants to merge 3 commits into
release-4.1.1-feed-countsfrom
release-4.1.1-top-level-comment-count

Conversation

@itsmeadi

Copy link
Copy Markdown
Contributor

Ticket

Summary

eBay is locked on the 4.1.1-feed-counts SDK. This copies the generated top-level comment count fields from the current OpenAPI regen onto that line, so GetActivity and GetComments can take include_top_level_comment_count without leaving 4.1.1. getFeedCounts is unchanged.

Checklist

  • The changed code has been covered with unit tests
  • API endpoints are covered with client tests
  • The internal documentation (./docs) has been updated

Notes for review

  • gradle.properties is still 4.1.1-feed-counts, which is already published. Cut a new version string before publishing to Maven.
  • GetActivityRequest was an empty class on 4.1.1, so the generated query field was copied in with the request annotations the generator uses (@Query, @JsonIgnore, @AllArgsConstructor).

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

This branch had an error being deployed

1 failed deployment
ci — 61ac749d Deployed Sep 30, 2026 by itsmeadi via 🧪 Test & lint #277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant