Fix NPE when general config section is missing in SlotDisplayEntity#36
Open
tommasov03 wants to merge 1 commit into
Open
Fix NPE when general config section is missing in SlotDisplayEntity#36tommasov03 wants to merge 1 commit into
tommasov03 wants to merge 1 commit into
Conversation
Guard config.getBoolean/getDouble calls against a null config field
(getConfigurationSection("general") returns null when that section
is absent from config.yml, e.g. on outdated configs), matching the
null-safe pattern already used elsewhere in ItemDisplayEntity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configbeingnullinSlotDisplayEntity/ItemDisplayEntitywhengetConfigurationSection("general")returnsnull, falling back to safe defaults instead of throwing.NullPointerExceptioninSlotDisplayEntity.initializeMetadata()that crashedClientboundAddEntityPackettranslation on every display-entity spawn.Root cause
getConfigurationSection("general")returnsnullwhen thegeneralsection is missing fromconfig.yml(e.g. configs generated by an older plugin version —FileUtils.createFilesonly creates the file if it doesn't exist yet, it never merges newly added keys into an existing config).SlotDisplayEntitythen calledconfig.getBoolean(...)unconditionally, causing an NPE on every entity spawn.Changes
SlotDisplayEntity.java: null-guard thevanilla-scale/vanilla-scale-multiplierlookups ininitializeMetadata(),setScale(), andapplyScale().ItemDisplayEntity.java: null-guard thehandlookup inupdateMainHand()and they-offsetlookup inmoveAbsoluteRaw(), matching the null-safe pattern already used elsewhere in the class.