Map the machine status "pause" to the "paused" status in HA. - #16
Merged
Conversation
The Creator 5 Pro goes into this state e. g. when a clog is detected. Map "downloading" to "busy" - debatable whether an extra HA status is required
GhostTypes
added a commit
that referenced
this pull request
Aug 8, 2026
Releases the "pause" and "downloading" status mappings from #16, which ff-5mp-hass needs before its own clog fix does anything: without this, a Creator 5 Pro sitting on a detected clog still reads "unknown" for Machine Status and off for Paused. Also corrects the #16 changelog's rationale for mapping "downloading" onto BUSY rather than a new enum member. The concern is real for a consumer that pins the enum to a fixed list, but ff-5mp-hass is not one: its ENUM sensor derives its options from MachineState, so a new member would reach it for free. Keeping BUSY for a patch release regardless - a new state is a design decision, not a bugfix. And makes test_empty_status_is_unknown_without_a_warning assert the absence it is named for; it checked the return value twice and never looked at caplog, so the no-warning guard was untested. Co-Authored-By: Claude Code <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TWz3MaKK9nJTTs3EpGjjkf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Creator 5 Pro goes into this state e. g. when a clog is detected.
Map "downloading" to "busy" - debatable whether an extra HA status is required