fix: do not roll back transaction on partial identity insert error#5
Open
amartinj wants to merge 3 commits into
Open
fix: do not roll back transaction on partial identity insert error#5amartinj wants to merge 3 commits into
amartinj wants to merge 3 commits into
Conversation
pepegar
approved these changes
Jul 1, 2026
sisca-goodnotes
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of upstream fix ory/kratos#4211 onto our
goodnotesbranch.Problem
When
CreateIdentitiesis called with a batch that contains conflicts, Kratos assigns UUIDs to identities and writes them to the accounts DB, but the identities are never persisted in Kratos's own DB. This leaves users in an inconsistent state — they exist in the accounts DB but cannot authenticate.Root cause:
partialErrwas returned from inside theTransaction()callback. SinceTransaction()rolls back on any non-nil error return, even the successfully-created identities get rolled back and never committed.Fix
Cherry-pick of upstream commit
82660f04e:persistence/sql/identity/persister_identity.go: declarepartialErroutside the transaction, returnnilfrom the callback (so successful identities are committed), returnpartialErr.ErrOrNil()after the transaction.identity/manager.go: addNewCreateIdentitiesError()constructor; fixErrOrNil()to handle nil receiver.Checklist