Add stress-ng app definition#1663
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new stress-ng application definition for Ramble. The review identifies that the matrix_method variable is currently unused and that the cpu_list variable is redundant. It is recommended to integrate matrix_method into the extra_args definition and remove the unused cpu_list variable to improve the API's cleanliness.
Ramble Performance Test MetricsResults produced with commit: 1414f5b
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1663 +/- ##
========================================
Coverage 93.31% 93.31%
========================================
Files 353 353
Lines 34334 34334
========================================
+ Hits 32039 32040 +1
+ Misses 2295 2294 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dapomeroy
left a comment
dapomeroy
left a comment
There was a problem hiding this comment.
Looks good! Thanks for adding this app. A couple questions about whether adding FOM details makes sense.
| + r"(?P<bogo_ops_per_s_usrsys>[0-9\.]+)" | ||
| ) | ||
|
|
||
| figure_of_merit( |
There was a problem hiding this comment.
Is there a FomType that fits this FOM?
| units="", | ||
| ) | ||
|
|
||
| figure_of_merit( |
There was a problem hiding this comment.
Same as above, is there a FomType that fits here?
| "Bogo Ops", | ||
| fom_regex=metrics_regex, | ||
| group_name="bogo_ops", | ||
| units="", |
There was a problem hiding this comment.
Should this be 'ops' since the FOM below is 'ops/s'?
2 participants
Example output: