Add infinite looping carousel/pager with auto-advance - #212
Open
dipenpradhan wants to merge 14 commits into
Open
Add infinite looping carousel/pager with auto-advance#212dipenpradhan wants to merge 14 commits into
dipenpradhan wants to merge 14 commits into
Conversation
dipenpradhan
force-pushed
the
issue-13-infinite-carousel
branch
from
September 8, 2026 06:38
8be0dcc to
9a4b123
Compare
- Replace compose/material3 version constants with composeBom - Strip explicit versions from BOM-managed artifacts - Import the BOM platform on every configuration that receives Compose artifacts (implementation, debugImplementation, androidTestImplementation, :data) - Migrate API removals that come with Compose 1.7 / Material3 1.3: SmallTopAppBar -> TopAppBar, rememberRipple -> material3 ripple - Update the outdated README Compose badge to the BOM version Fixes Gurupreet#186
All lifecycle artifacts (viewmodel-compose, viewmodel-ktx, livedata-ktx, runtime-ktx, viewmodel-savedstate) move together via the shared androidLifecycleGrouped version. Fixes Gurupreet#192
- navCompose 2.7.7 -> 2.8.9; add kotlinx-serialization-json 1.8.0 - Apply the Kotlin serialization plugin in gmail and tiktok demos - Gmail: string routes -> @serializable route objects - TikTok: TikTokScreen becomes a serializable sealed interface; the profile route carries a typed userId argument read via toRoute(), bottom bar selection uses NavDestination.hasRoute Fixes Gurupreet#193
- Replace com.google.android.exoplayer:exoplayer with androidx.media3:media3-exoplayer and media3-ui - Rewrite TikTokPlayer against the Media3 API (SimpleExoPlayer was removed; default media source factory handles asset URIs) - Removes the last Jetifier warning produced by ExoPlayer 2.x Fixes Gurupreet#183
- Move to the io.coil-kt.coil3 artifact group - Add coil-network-okhttp (network fetching is a separate artifact in Coil 3, self-registered via ServiceLoader) - Migrate call sites: rememberImagePainter(data=) -> rememberAsyncImagePainter(model=), coil.* -> coil3.* imports Fixes Gurupreet#191
PullRefreshList was a fully commented-out stub (TODO revisit pull refresh). It now demonstrates the first-party PullToRefreshBox with a simulated 1.5s reload that prepends an item to the list. Fixes Gurupreet#187
Covers the new composables added here so the feature ships with its own verification rather than relying on a later change in the stack.
dipenpradhan
force-pushed
the
issue-13-infinite-carousel
branch
from
September 8, 2026 08:47
9a4b123 to
d94c5bc
Compare
The Swipeable Lists tab rendered SwipeToDismissBox items but swipes never removed anything. Now: - swipe left deletes (red background), swipe right archives - items are actually removed from the keyed LazyColumn - an Undo snackbar restores the item at its original position - positionalThreshold set to half the item width Fixes Gurupreet#188
Adds UI tests for the composables introduced here so the feature ships with its own verification. The undo test surfaced a real defect: tapping Undo re-added the album to the backing list, but LazyColumn keeps the first visible item anchored, so a row re-inserted above it silently landed off-screen and the user saw nothing happen. The list now holds a LazyListState and scrolls the restored row back into view.
- NavigationSuiteScaffold switches bottom bar / rail / drawer by window size class - ListDetailPaneScaffold gives single-pane on phones, two-pane on tablets and foldables, with predictive-back-aware pane navigation - Favorites/Profile destinations display the live window size classes - All adaptive artifacts are version-managed by the Compose BOM Fixes Gurupreet#190
Covers the new composables added here so the feature ships with its own verification rather than relying on a later change in the stack.
InfiniteCarousel builds on foundation's HorizontalPager with a large virtual page count starting in the middle, so it loops endlessly in both directions. Auto-advances every 3s and pauses while dragging. Showcased at the top of the Carousel demo screen. Fixes Gurupreet#13
Adds InfiniteCarouselTest so the carousel ships with its own verification instead of relying on a later change in the stack. The convention plugin now sets testInstrumentationRunner so library modules can host androidTests. Swipe gestures target the root rather than the Text node inside a page: a gesture is dispatched over the bounds of the node it is performed on, and a Text node is far too narrow to cross the pager's paging threshold.
4 tasks
dipenpradhan
force-pushed
the
issue-13-infinite-carousel
branch
from
September 9, 2026 06:45
d94c5bc to
e20aa00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an infinite looping carousel/pager, as requested in #13 (and complementing the partial backward-scroll support added in #177).
New
InfiniteCarouselcomposable incomponents:carousel, built on foundation'sHorizontalPager:interactionSource.collectIsDraggedAsState)content: @Composable (Item) -> Unit) so any card style can be usedShowcased as a new top section in the existing Carousel demo screen (Home → Carousel), reusing the existing
CarouselItemcard.Closes #13
Verification
InfiniteCarouselTest(3 tests) — covers forward paging, backward looping past the first item, and indicator state../gradlew ktfmtCheck assembleDebug testDebugUnitTestpasses locally (JDK 17, SDK 35)./gradlew buildon this PRcc @Gurupreet for review