[Feature] 截图管理#6096
Conversation
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
# Conflicts: # HMCL/src/main/resources/assets/css/root.css
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/VersionPage.java
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new screenshots management page (ScreenshotsPage) for Minecraft versions, allowing users to view, copy, delete, and filter screenshots by date. It also integrates JFXDatePicker and JFXDatePickerSkin to support date range selection, along with corresponding CSS styles, localization properties, and file size formatting utilities. Feedback on the changes highlights several critical improvements: performing blocking file I/O and large image loading asynchronously on background threads to avoid freezing the JavaFX UI, adding defensive null checks to prevent NullPointerExceptions, ensuring thread safety for cross-thread image fields using volatile, respecting user-configured locales during date formatting, and protecting against an ArrayIndexOutOfBoundsException when removing listeners.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
3 participants
Resolves #5535