[Enhancement] 无论何时都显示关闭愚人节模式的按钮#6105
Conversation
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/util/AprilFools.java
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the April Fools settings logic by removing the conditional check AprilFools.isShowAprilFoolsSettings(). As a result, the toggle button to disable April Fools is now always visible in the settings page, and the unused isShowAprilFoolsSettings method and SHOW_APRIL_FOOLS_SETTINGS field have been removed from the AprilFools utility class. There are no review comments to address, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
CC @Glavo gemini非常满意 |
|
我觉得可以把时间放宽一点，但没必要一年到头都显示啊。 |
这个选项放着也不碍事，而且放宽时限放宽到多少也没个定论，还不如一直开放。况且用户应该始终拥有决定权 |
3 participants
Closes #5982