Skip to content

fix: refresh rxiv-maker citation authors - #314

Merged
paxcalpt merged 3 commits into
mainfrom
fix/citation-authors-v1.22.2-release
Jul 13, 2026
Merged

fix: refresh rxiv-maker citation authors#314
paxcalpt merged 3 commits into
mainfrom
fix/citation-authors-v1.22.2-release

Conversation

@paxcalpt

Copy link
Copy Markdown
Contributor

Summary

  • add Rita Carlota and Iván Hidalgo-Cenalmor to the canonical Rxiv-Maker citation
  • refresh old injected citations on rebuild
  • bump version to 1.22.2 and update bundled citation references

Verification

  • uv run --with pytest pytest tests/integration/test_citation_injection.py -q
  • uv run --with ruff ruff check src/rxiv_maker/utils/citation_utils.py tests/integration/test_citation_injection.py
  • uv build

@github-actions

Copy link
Copy Markdown

🔗 Link Check Failed

Some links in the documentation are broken:

Summary

Status Count
🔍 Total 146
🔗 Unique 79
✅ Successful 133
⏳ Timeouts 0
🔀 Redirected 5
👻 Excluded 11
❓ Unknown 0
🚫 Errors 2
⛔ Unsupported 0

Errors per input

Errors in README.md

Errors in tests/visual/README.md

  • [ERROR] error: (at 47:3) | Empty URL found but a URL must not be empty

Redirects per input

Redirects in CODE_OF_CONDUCT.md

Redirects in docs/google_colab.md

Redirects in README.md

Full Github Actions output


💡 Tip: Check the full report artifact for details.

@github-actions

Copy link
Copy Markdown

🔗 Link Check Failed

Some links in the documentation are broken:

Summary

Status Count
🔍 Total 146
🔗 Unique 79
✅ Successful 133
⏳ Timeouts 0
🔀 Redirected 5
👻 Excluded 11
❓ Unknown 0
🚫 Errors 2
⛔ Unsupported 0

Errors per input

Errors in README.md

Errors in tests/visual/README.md

  • [ERROR] error: (at 47:3) | Empty URL found but a URL must not be empty

Redirects per input

Redirects in CODE_OF_CONDUCT.md

Redirects in docs/google_colab.md

Redirects in README.md

Full Github Actions output


💡 Tip: Check the full report artifact for details.

@github-actions

Copy link
Copy Markdown

Code Review

Reviewed the diff for #314 (author refresh for the canonical Rxiv-Maker citation, v1.22.2).

Overall: small, well-scoped fix. The refresh logic (is_citation_outdated / inject_rxiv_citation in citation_utils.py) correctly detects and replaces stale citations, and this pattern is consistent with the prior "Jaquemet → Jacquemet" fix in 1.22.1. Test coverage for the new behavior looks solid (test_citation_injection_refreshes_stale_entry plus updated unit tests).

Minor issues

  1. Inconsistent LaTeX escaping introduced in README.md (line 86):

    author={Bruno M. Saraiva and Rita Carlota and Ant\'{o}nio D. Brito and Iván Hidalgo-Cenalmor and Guillaume Jacquemet and Ricardo Henriques},
    

    António uses the LaTeX-escaped form (Ant\'{o}nio, pre-existing style in this file) but the newly added Iván uses a plain Unicode á. MANUSCRIPT/03_REFERENCES.bib is consistent (Iv\'{a}n), so this is a one-line drift in the README only. Cosmetic since it's a Markdown snippet rather than compiled LaTeX, but worth fixing for consistency — Iv\'{a}n.

  2. Three independently-maintained copies of the author string (citation_utils.py, README.md, MANUSCRIPT/03_REFERENCES.bib) with no test tying them together. This PR (and the fact that issue Add Claude Code GitHub Workflow #1 above slipped through) shows how easy it is for these to drift. Not a blocker, but a test asserting README.md's citation matches CANONICAL_RXIV_CITATION (modulo LaTeX escaping) would catch this class of bug going forward.

  3. Unrelated .gitignore change (.worktrees/) — harmless, but it's not mentioned in the PR summary and looks like it may be leftover from local tooling rather than part of the citation fix. Worth confirming it's intentional.

Security / performance

No concerns — this is a self-citation string change plus a regex-based find/replace against a local file. No new attack surface (path handling unchanged from prior version, still resolves MANUSCRIPT_PATH under the current working directory as before).

Test coverage

Good — new integration test covers the "refresh stale entry" path end-to-end, and existing unit/integration tests were updated to reflect the new author list including the negative assertion that the old string is gone.

@paxcalpt
paxcalpt merged commit 83ed680 into main Jul 13, 2026
9 of 10 checks passed
@paxcalpt
paxcalpt deleted the fix/citation-authors-v1.22.2-release branch July 13, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant