Skip to content

Potential fix for code scanning alert no. 2: Incorrect conversion between integer types #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HilthonTT merged 1 commit into from
Aug 5, 2026
Merged

Potential fix for code scanning alert no. 2: Incorrect conversion between integer types #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion internal/compiler/parser/data_type_parsing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package parser

import (
"math/bits"
"strconv"
"strings"

Expand All @@ -10,6 +11,13 @@ import (
"github.com/hilthontt/luascript/internal/compiler/token"
)

func int64FromUint64Bits(u uint64) int64 {
// Reinterpret the 64-bit pattern as signed, preserving Lua's modulo 2^64
// integer literal semantics without relying on a direct narrowing cast.
hi, lo := bits.Add64(u, 0, 0)
return int64((hi << 63 << 1) | lo)
}

func (p *Parser) parseIntegerLiteral() ast.Expression {
tok := p.curToken
lit := tok.Literal
Expand All @@ -18,7 +26,7 @@ func (p *Parser) parseIntegerLiteral() ast.Expression {
// (0xFFFFFFFFFFFFFFFF == -1), so parse unsigned and reinterpret.
if u, err := strconv.ParseUint(lit[2:], 16, 64); err == nil {
p.nextToken()
return &ast.IntegerLiteral{BaseNode: baseAt(tok), Value: int64(u)}
return &ast.IntegerLiteral{BaseNode: baseAt(tok), Value: int64FromUint64Bits(u)}
}
p.error = errors.NewTypeParsingError(lit, "Integer", tok.Line)
return nil
Expand Down
Loading