Skip to content

feat(web): move the runtime page onto the dictionary spine (#5337) - #6797

Merged
Hmbown merged 1 commit into
Hmbown:mainfrom
Lstarsky0:feat/runtime-dictionary-spine
Sep 30, 2026
Merged

Hmbown merged 1 commit into
Hmbown:mainfrom
Lstarsky0:feat/runtime-dictionary-spine

Conversation

@Lstarsky0

Copy link
Copy Markdown
Contributor

Summary

The runtime page was still forking its copy on isZh. Its strings move to runtime.ts behind getRuntime, held to the page-body contract next to the constitution page. Copy is verbatim.

The integration descriptions and the four trust-boundary items are content in both languages, so they stay in the page and are read with pickText, like the constitution page's layers: desc/descZh becomes one desc pair, and the trust items move from the component body up to a module-level TRUST next to INTEGRATIONS. public-copy.test.ts still finds the ACP and VS Code descriptions in the page source, so it needs no change.

CEILING goes to 2, the count the test now reports (the two admin files), and check-locales.mjs now lists runtime.ts.

No-Issue: one more page of the #5337 migration.

Testing

Web only, no Rust touched. From web/:

  • npm test — 629 passed
  • npm run check — clean
  • node scripts/check-locales.mjs — passes, and fails if zh drops a key

Rendered runtime, main vs this branch, all 18 locales: body text, <title>/description/og:/twitter: meta and the lang/href attributes identical once the Source revision cell, which prints each build's own commit, is normalized. As a control, the comparison flags a one-character change to the zh kicker, the zh Experimental badge, one zh trust item, one zh integration description and the zh description, and the zh title-aside lang changed to en-US.

Checklist

  • This PR adds a new layer/module/abstraction — n/a
  • Updated docs or comments as needed
  • Added or updated tests where relevant
  • Verified TUI behavior manually if UI changes — n/a
  • Harvested/co-authored credit uses a GitHub numeric noreply address

Copy moved verbatim. The integration descriptions and the four
trust-boundary items are content in both languages, so they stay in
the page as en/zh pairs read with pickText, like the constitution
page's layers; the trust items move up to module level next to the
integrations. CEILING drops to the new count of 2 (the two admin
files), and check-locales now covers runtime.ts.

Signed-off-by: Lstarsky0 <59827030+Lstarsky0@users.noreply.github.com>
@Lstarsky0
Lstarsky0 requested a review from Hmbown as a code owner September 30, 2026 14:07
@github-actions github-actions Bot added the contribution-gate Author not yet in .github/APPROVED_CONTRIBUTORS; a maintainer grants access with /lgtm label Sep 30, 2026
@Hmbown
Hmbown merged commit c76bbfb into Hmbown:main Sep 30, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution-gate Author not yet in .github/APPROVED_CONTRIBUTORS; a maintainer grants access with /lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants