feat(web): move the runtime page onto the dictionary spine (#5337) - #6797
Merged
Merged
Conversation
Copy moved verbatim. The integration descriptions and the four trust-boundary items are content in both languages, so they stay in the page as en/zh pairs read with pickText, like the constitution page's layers; the trust items move up to module level next to the integrations. CEILING drops to the new count of 2 (the two admin files), and check-locales now covers runtime.ts. Signed-off-by: Lstarsky0 <59827030+Lstarsky0@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The runtime page was still forking its copy on
isZh. Its strings move toruntime.tsbehindgetRuntime, held to the page-body contract next to the constitution page. Copy is verbatim.The integration descriptions and the four trust-boundary items are content in both languages, so they stay in the page and are read with
pickText, like the constitution page's layers:desc/descZhbecomes onedescpair, and the trust items move from the component body up to a module-levelTRUSTnext toINTEGRATIONS.public-copy.test.tsstill finds the ACP and VS Code descriptions in the page source, so it needs no change.CEILINGgoes to 2, the count the test now reports (the two admin files), andcheck-locales.mjsnow listsruntime.ts.No-Issue: one more page of the #5337 migration.
Testing
Web only, no Rust touched. From
web/:npm test— 629 passednpm run check— cleannode scripts/check-locales.mjs— passes, and fails if zh drops a keyRendered
runtime, main vs this branch, all 18 locales: body text,<title>/description/og:/twitter:meta and thelang/hrefattributes identical once the Source revision cell, which prints each build's own commit, is normalized. As a control, the comparison flags a one-character change to the zh kicker, the zh Experimental badge, one zh trust item, one zh integration description and the zh description, and the zh title-asidelangchanged toen-US.Checklist