Skip to content

Fix ≻ and ⪰ to compare the correct endpoints - #23

Merged
timholy merged 1 commit into
mainfrom
teh/fixgt
Sep 5, 2026
Merged

Fix ≻ and ⪰ to compare the correct endpoints#23
timholy merged 1 commit into
mainfrom
teh/fixgt

Conversation

@timholy

@timholy timholy commented Sep 5, 2026

Copy link
Copy Markdown
Member

≻(a, b) and ⪰(a, b) compared hival(a) against loval(b), so they returned true for overlapping spans. The docstrings specify loval(a) > hival(b) and loval(a) >= hival(b); the implementations now match, and tests check that overlapping spans are unordered.

Also fix the wording of the isempty docstring.

Assisted-by: Claude Fable 5.1 noreply@anthropic.com

@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.87%. Comparing base (778b20c) to head (872ad86).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   93.87%   93.87%           
=======================================
  Files           2        2           
  Lines         147      147           
=======================================
  Hits          138      138           
  Misses          9        9           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timholy
timholy merged commit dd5c79c into main Sep 5, 2026
5 checks passed
@timholy
timholy deleted the teh/fixgt branch September 5, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant