Add isthick trait for non-subtype implementations - #24
Merged
Conversation
`isthick(T)` returns whether a type implements the ThickNumbers
interface. Subtypes of `ThickNumber` return `true` automatically;
a type with another supertype opts in by defining
`isthick(::Type{<:T}) = true` and the required methods.
`isempty_tn` is the name such types implement in place of
`Base.isempty(::ThickNumber)`, which now forwards to it.
The developer docs list the requirements, and the interface tests
check `isthick`.
Assisted-by: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 93.87% 94.00% +0.12%
==========================================
Files 2 2
Lines 147 150 +3
==========================================
+ Hits 138 141 +3
Misses 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isthick(T)returns whether a type implements the ThickNumbers interface. Subtypes ofThickNumberreturntrueautomatically; a type with another supertype opts in by definingisthick(::Type{<:T}) = trueand the required methods.isempty_tnis the name such types implement in place ofBase.isempty(::ThickNumber), which now forwards to it.The developer docs list the requirements, and the interface tests check
isthick.Assisted-by: Claude Fable 5.1 noreply@anthropic.com