Conversation
krowvin
commented
Sep 22, 2026
| if req.get("max_version"): | ||
| constraints.append(f"<{req['max_version']}") | ||
| version_range = ",".join(constraints) | ||
| supported = SpecifierSet(version_range) |
Collaborator
Author
There was a problem hiding this comment.
This should resolve the issue you found with it being treated as 0.1 instead of 10 on the PATCH bump
Collaborator
Author
|
Will revisit <>, spoke with @Enovotny and he was able to complete work to resolve the version issue here |
Generate dependency installation commands with sys.executable -m pip so packages are installed into the environment running cwms-cli. Include --upgrade when installing supported version ranges to replace outdated packages such as cwms-python 0.5.0. AI assisted
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commands currently check only minimum dependency versions, so an installed cwms-python 2.x can reach command code even though the development dependency targets 1.x. Add an optional exclusive
max_versionto the shared guard and enforcecwms-python>=1.0.7,<2.0.0at runtime and in the DSS extra. Unsupported versions produce a Click error with instructions to upgrade cwms-cli or install a compatible library version; missing-package instructions also include the supported range.Make
packaginga runtime dependency and remove the fallback to string comparison. This preserves numeric version ordering (1.0.10is newer than1.0.7) and rejects unparseable installed versions. Existing minimum-only requirements keep their behavior. The 2.0 boundary follows the existing^1.0.7development constraint; it does not assert that a currently released cwms-python version is known to be incompatible. The reported double-digit version warning was a separate comparison bug already partially addressed on main.Validation:
cwms-clibecause an existing update test assumes that directory name.