Conversation
zack-rma
force-pushed
the
feature/project-sublocations
branch
from
August 31, 2026 16:37
e6dcd72 to
823b937
Compare
…user and contracts.
zack-rma
force-pushed
the
feature/project-sublocations
branch
from
August 31, 2026 16:50
823b937 to
3aa0701
Compare
…om lookup deletion.
Contributor
Author
|
Resolved test failure caused by bug in CDA: USACE/cwms-data-api#1920 |
zack-rma
marked this pull request as ready for review
September 4, 2026 00:25
krowvin
changed the title
krowvin
requested changes
Sep 11, 2026
krowvin
left a comment
krowvin
left a comment
Collaborator
There was a problem hiding this comment.
Resolve failed CI, possibly merge main into see if the tests start passing
Collaborator
|
Will need to resolve the quality checks too, see if we can combine a bit |
Collaborator
|
Might centralize some of the test data so it can be re-used elsewhere |
…cations # Conflicts: # cwms/locations/lookups.py
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial implementation of water user, water contract, and lock endpoints. Tests to come.