ci: restore production CDA integration checks on PRs - #323
Merged
Merged
Conversation
krowvin
marked this pull request as ready for review
September 22, 2026 01:56
|
Enovotny
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore integration feedback before merge: ordinary PRs run production CDA with the production database/schema on Python 3.9 and latest stable (two jobs). Release Please branches run the full 18 combinations. All jobs continue to use disposable local Docker backends.
Rename the workflow to CDA integration (PR production, weekly exhaustive) and retain exhaustive manual runs. The existing schedule was nightly; change it to Monday at 08:17 UTC to match the intended weekly coverage. Cancel superseded runs and preserve existing image pins, job names, and backend diagnostics.
Update contributor guidance to require all 18 results on the current release PR revision before merge, including the reopen/manual-run workaround for PRs created with GITHUB_TOKEN. Repository merge rules are unchanged; release-only enforcement remains a maintainer check.
Validation: actionlint, repository yamlfix/pre-commit, and whitespace checks passed. Parsed-workflow checks confirm two jobs for ordinary PRs and 18 for release PRs, schedule, and manual dispatch, with matching database/installer tags. Docker integration execution is left to GitHub CI; these local checks do not prove backend tests pass.
Includes the existing test fix from #320: use a unique location, assert its catalog row, and clean it up in finally. Both restored production jobs exposed the old empty-catalog assumption (five seeded locations; 82 other tests passed in each job). Local validation after integrating the fix: 98 mock/doctest tests, Black, isort, and whitespace checks passed. GitHub run 35674794931 passed all 83 integration tests on both Python 3.9 and latest stable; all 11 PR checks passed on c942a22.
Related: #315 (CI trigger changes), #320 (included location integration test fix).