-
Notifications
You must be signed in to change notification settings - Fork 12
Trace winning auction bids to rendered creatives on the page #922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prk-Jr
wants to merge
12
commits into
main
Choose a base branch
from
trace-auction-winners-to-creatives
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
397a4d6
Trace winning auction bids to rendered creatives on the page
prk-Jr 966c856
Add /_ts/trace overlay to confirm creatives render on the page
prk-Jr e1a8b81
Trace client-side /auction renders and stop overclaiming GAM renders
prk-Jr 4f45974
Recover GPT slots orphaned by a client re-render
prk-Jr 9e46233
Show the render trace as a timeline and badge every rendered slot
prk-Jr 27a4727
Stop attributing GAM refreshes to the finished server-side auction
prk-Jr 7b7c466
Number every render and keep GAM's fill signal on refresh rows
prk-Jr 2c482d7
Show absent attribution as — instead of ? in trace tooltips
prk-Jr 50ce368
Trace SSAT creatives the Universal Creative bridge renders inline
prk-Jr b0f31ef
Fall back to the OpenRTB bid id for hb_adid when cache_id and ad_id a…
prk-Jr 3a6b7fd
Merge remote-tracking branch 'origin/main' into trace-auction-winners…
prk-Jr 03aa5ec
Correct render tracing across auction paths
prk-Jr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 wrench —
adm_hashis computed over two different byte-streams, so the documented log join silently fails on the/auctionpath.This line hashes
creative_html, i.e. the creative aftersanitize_creative_html+rewrite_creative_html. Butlog_winning_bids(orchestrator.rs:174) andbuild_bid_map(publisher.rs:2146) both hash the rawbid.creativeviaBid::creative_trace_hash().One winning bid therefore emits two different
adm_hashvalues across the two new info logs, and the value the client stamps into the DOM depends on which path served it. The doc comments onstampCreativeTrace,build_bid_map, and thetrace.tsheader all explicitly promise that the DOM marker "joins back to the server-sideauction winner:log lines" — on the/auctionpath that join can never match.I checked the SSAT /
inject_adm_for_testingpath and it is self-consistent (the bid map'sadmis also rawbid.creative), so this is scoped to/auction.Fix — either hash one canonical form on both paths, or name the two distinctly and log both on the winner line so the relationship is explicit (e.g.
adm_hash_rawonauction winner:,adm_hash_deliveredhere).Additionally: this PR should be stacked on top of #916. That PR ("Make auction creative rewriting optional") rewrites this exact block — it replaces the
rewrittenbinding with aprocessedone gated onsettings.auction.rewrite_creatives. Two consequences:adm_hashbecomes a hash of sanitized-only output or sanitized+rewritten output depending onrewrite_creatives. The same creative would then produce differentadm_hashvalues across deployments, on top of already differing from the raw hash on theauction winner:line.#916 is smaller and already
MERGEABLE, so the cheap ordering is to land it first and rebase this PR onto it, definingadm_hashagainst #916's finalprocessedvalue with the raw/delivered naming split above.