fixrule(list_markup_review): rewrite list_markup_review detection logic - #2608
Merged
Conversation
- Scope checks to block-level elements and td/th only, preventing duplicate reports from ancestor/descendant pairs - Accumulate inline sibling text across <br> boundaries before testing against list-item pattern, fixing detection of mixed inline content (e.g. `• <strong>text</strong>`) - Add td/th early-exit before ancestor role check to prevent implicit table ARIA roles from blocking detection - Require 2+ consecutive matching lines before flagging, eliminating single-item false positives - Expand LIST_ITEM_PATTERN to cover: •◦▪▸► ✓✗✦ –— * - o and ordered variants: 1. 1) (1) a. a) A. A) i. ii. iii. - Preserve lastWasBr state across whitespace-only text nodes - Skip elements inside script, style, label, and hidden containers
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2515 for original