feat(torch): add flash_attn_varlen_func operator#802
Merged
Conversation
flash_attn_varlen_func operator
voltjia
marked this pull request as ready for review
July 22, 2026 05:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flash_attn_varlen_funcoperator with the parameter order and defaults of Dao-AILab FlashAttention FA2.Motivation
This is the first representative FlashAttention operator migrated into InfiniOps. It establishes the public operator boundary without vendoring or exposing a third-party package: callers use the upstream-aligned InfiniOps API, while the first provider is the PyTorch CUDA backend already available to
WITH_TORCHbuilds.N/A - no linked issue.
API Alignment
The public argument order follows Dao-AILab FlashAttention commit
10846960:InfiniOps uses its normal trailing
outexecution argument. The backend maps this API to PyTorch's privateaten::_flash_attention_forwardoperator.Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Remote environment:
ssh nvidia,accelerator-dev/nvidia:latest, NVIDIA A100-SXM4-80GB, PyTorch2.10.0a0+b4e4ee81d3.nv25.12, CUDA 13.1.Test Results on Supported Platforms
20 passedAdditional validation
Benchmark / Performance Impact
N/A - this PR establishes an API and correctness path; it makes no performance claim. The ATen result is copied into the InfiniOps trailing
outtensor.Notes for Reviewers
dropout_p=0,softcap=0, no ALiBi slopes, no deterministic/probability return mode, and no pagedblock_table.scripts/torch_ops.yamlis intentionally unchanged.accelerator-dev/moore:latestprovides MUSA 4.3.1, TorchMUSA 2.5, and MATE 0.0.0; the pinned MATE v0.1.3 target requires newer MUSA/TorchMUSA. It should be added as a separate provider PR after the image/toolchain is upgraded.