Conversation
|
|
LouisCAD
marked this pull request as ready for review
August 13, 2026 11:44
LouisCAD
enabled auto-merge
August 13, 2026 11:44
Contributor
There was a problem hiding this comment.
Pull request overview
Adds integration guidance for TwoFactorAuth polling, UI overlays, and push notifications.
Changes:
- Documents manager setup with or without Core’s user database.
- Documents Compose overlay integration.
- Adds Google Play Services notification setup guidance.
Suppressed comments (2)
TwoFactorAuth/README.md:149
- The integration checklist omits the Android 13+ runtime notification permission. Although the manifest permission is merged from the Notifications module,
notifyCompatdeliberately skips posting whenPOST_NOTIFICATIONShas not been granted, so a new app following every listed step can still receive pushes without showing the 2FA notification.
Here's the list of changes you need to add from the example PRs above:
1. Ensure `TwoFactorAuthNotifications.channel()` is created/submitted to Android's NotificationManager.
TwoFactorAuth/README.md:95
- The published extension is named
addComposeOverlay, notaddComposableOverlay(TwoFactorAuth/Front/src/main/kotlin/ComposeOverlayHosting.kt:30). As written, both the instruction and example reference a nonexistent API and will not compile.
If the Activity is NOT using Compose, or if you don't know (e.g. in a `BaseActivity` class), the `addComposableOverlay`
function was made just for that, just make sure it's called after `setContentView` or `setContent`.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.