Fix #2416 - refresh closed Koin context in Compose - #2467
Open
AvikMakwana wants to merge 2 commits into
Open
Conversation
AvikMakwana
marked this pull request as ready for review
September 8, 2026 09:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
getKoin()could return a staleKoininstance after astopKoin()/startKoin()cycle.LocalKoinApplicationContextcaches the firstKoininstance throughComposeContextWrapper. After that instance is closed,getKoin()still returned the cached value becausegetValue()itself succeeded, so the existing exception recovery path was never reached.Dependency resolution then failed with:
ClosedScopeException: Scope '_root_' is closedFix
getKoin()now checks whether the cached Koin instance's root scope is closed and resets the context when necessary, following the same recovery pattern already used bycurrentKoinScope().This keeps locally provided Compose Koin contexts intact rather than replacing them with the global context.
Tests
Added regression coverage for:
stopKoin()→startKoin()resolving the new Koin instanceKoinIsolatedContextKoinApplicationPreviewThe restart regression test fails on the previous implementation with
ClosedScopeExceptionand passes with this change.Validation
Passed:
./gradlew :compose:koin-compose:jvmTest --rerun-tasks./gradlew :compose:koin-compose:apiCheck./gradlew :compose:koin-compose:compileTestKotlinWasmJs./gradlew :compose:koin-compose:compileTestKotlinJs./gradlew :compose:koin-compose:compileTestKotlinIosX64The root
./gradlew apiCheckcompleted successfully for the library modules;:core:benchmark:jvmApiBuildhas an unrelated failure under JDK 24 due to the binary compatibility validator not supporting bytecode level 68.Fixes #2416