Skip to content

task: add broadcast class implementation - #2901

Merged
antonwolfy merged 11 commits into
masterfrom
task/SAT-7028
Aug 20, 2026
Merged

task: add broadcast class implementation#2901
antonwolfy merged 11 commits into
masterfrom
task/SAT-7028

Conversation

@jharlow-intel

@jharlow-intel jharlow-intel commented May 6, 2026

Copy link
Copy Markdown
Collaborator

Adds a broadcast class implementation

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@jharlow-intel jharlow-intel self-assigned this May 6, 2026
@jharlow-intel jharlow-intel added the enhancement New feature or request label May 6, 2026
@jharlow-intel jharlow-intel changed the title task: add boradcast class implementation task: add broadcast class implementation May 6, 2026
@jharlow-intel
jharlow-intel marked this pull request as draft May 6, 2026 19:53
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Comment thread dpnp/dpnp_broadcast.py Outdated
Comment thread dpnp/dpnp_broadcast.py Outdated
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Array API standard conformance tests for dpnp=0.21.0dev5=py314ha0e2e8e_14 ran successfully.
Passed: 1376
Failed: 1
Skipped: 5

@jharlow-intel
jharlow-intel requested a review from antonwolfy May 26, 2026 19:25
Comment thread dpnp/dpnp_broadcast.py Outdated
Comment thread dpnp/dpnp_broadcast.py Outdated
@jharlow-intel
jharlow-intel marked this pull request as ready for review August 7, 2026 14:21
@coveralls

coveralls commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 78.477% (+0.02%) from 78.458% — task/SAT-7028 into master

Comment thread dpnp/dpnp_broadcast.py Outdated
Comment thread dpnp/dpnp_broadcast.py Outdated
Comment thread dpnp/dpnp_broadcast.py Outdated
Comment thread CHANGELOG.md Outdated
Comment thread dpnp/dpnp_broadcast.py Outdated
Comment thread dpnp/dpnp_broadcast.py Outdated
Comment thread dpnp/dpnp_broadcast.py Outdated
Comment thread dpnp/dpnp_broadcast.py Outdated
Comment thread dpnp/dpnp_broadcast.py Outdated
jharlow-intel and others added 5 commits August 13, 2026 09:26
Add an Attributes section to the dpnp.broadcast class docstring so the
attributes (shape, size, ndim, numiter, values) render on the class page
the way numpy/cupy present them, and drop the now-redundant per-attribute
autosummary entries from the reference. Also document broadcast_arrays'
variadic parameter as *args for consistency with broadcast/broadcast_shapes.
Use a dedicated autosummary template for the broadcast class that keeps
the Attributes rubric visible (instead of the default template which hides
member tables), so shape/size/ndim/numiter/values render under an
"Attributes" heading like numpy/cupy, rather than the "Variables" label
produced by a napoleon Attributes docstring section. Also add "numiter"
to the docs spell-check word list.
Prefix the autosummary entries with ~ so the Attributes table lists the
attributes by their short names (shape, size, ndim, numiter, values)
instead of the fully qualified broadcast.<name> form.

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope it will be rendered properly now.
Thank you @jharlow-intel for the main implementation.

@antonwolfy
antonwolfy merged commit 7a52728 into master Aug 20, 2026
102 of 108 checks passed
@antonwolfy
antonwolfy deleted the task/SAT-7028 branch August 20, 2026 08:55
github-actions Bot added a commit that referenced this pull request Aug 20, 2026
Adds a `broadcast` class implementation 7a52728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants