Skip non-conformant array API DLPack and flaky tanh conformity tests - #3034
Open
antonwolfy wants to merge 3 commits into
Open
Skip non-conformant array API DLPack and flaky tanh conformity tests#3034antonwolfy wants to merge 3 commits into
antonwolfy wants to merge 3 commits into
Conversation
test_dunder_dlpack pins the requested dl_device to kDLCPU while independently
drawing copy from {True, False, None}. A dpnp array always reports its DLPack
device as kDLOneAPI (never kDLCPU), even when the backing SYCL device is a CPU,
so the copy=False case forces a cross-device export. The array API standard
requires that such a no-copy cross-device transfer be rejected with a
BufferError, which dpnp/dpctl correctly raises. The test wraps the call in a
bare except and treats any exception as a failure, so it fails on
spec-compliant behavior. Skip it, matching how other device-backed libraries
(e.g. CuPy) handle the same test.
Reference the tracking issues in the skips file and add test_unary[tanh(...) -> 1 + 0j], which intermittently fails because the sign of the imaginary zero in the result is unstable (out=(1-0j) vs the expected 1 + 0j).
antonwolfy
changed the title
Collaborator
|
@antonwolfy what is the cause of non-conformance of the DLPack tests? Has it been investigated? |
Contributor
Author
I placed links per each associated skipped test |
ndgrigorian
reviewed
Aug 19, 2026
Co-authored-by: ndgrigorian <46709016+ndgrigorian@users.noreply.github.com>
antonwolfy
marked this pull request as ready for review
August 19, 2026 21:03
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev5=py314ha0e2e8e_6 ran successfully. |
Collaborator
|
coverage: 78.458%. remained the same — skip/array-api-dunder-dlpack into master |
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/3034/index.html |
vlad-perevezentsev
approved these changes
Aug 20, 2026
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two entries to the array API conformity skips file, each tracked by an upstream issue.