Define PACKAGE_NAME env var in build-docs workflow - #153
Merged
Conversation
The 'Save built docs as an artifact' step references ${{ env.PACKAGE_NAME }}
in the artifact name, but the variable was never defined in this workflow,
producing an artifact named ' rendered documentation' with a leading space.
Define PACKAGE_NAME at the workflow level, matching the convention used in
conda-package.yml.
antonwolfy
requested review from
jharlow-intel,
ndgrigorian,
vlad-perevezentsev and
xaleryb
as code owners
August 5, 2026 12:49
ndgrigorian
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Save built docs as an artifactstep inbuild-docs.ymlnames the artifact using${{ env.PACKAGE_NAME }}:However,
PACKAGE_NAMEis never defined in this workflow (noenv:block at the workflow, job, or step level). The expression expands to an empty string, so the uploaded artifact is named" rendered documentation"with a leading space.Change
Define
PACKAGE_NAME: mkl_randomat the workflow level, matching the convention already used inconda-package.ymlandconda-package-cf.yml. The artifact is now correctly namedmkl_random rendered documentation.