Skip to content

Define PACKAGE_NAME env var in build-docs workflow - #153

Merged
ndgrigorian merged 1 commit into
masterfrom
fix-docs-artifact-name
Aug 5, 2026
Merged

Define PACKAGE_NAME env var in build-docs workflow#153
ndgrigorian merged 1 commit into
masterfrom
fix-docs-artifact-name

Conversation

@antonwolfy

Copy link
Copy Markdown
Collaborator

Summary

The Save built docs as an artifact step in build-docs.yml names the artifact using ${{ env.PACKAGE_NAME }}:

- name: Save built docs as an artifact
  ...
  with:
    name: ${{ env.PACKAGE_NAME }} rendered documentation

However, PACKAGE_NAME is never defined in this workflow (no env: block at the workflow, job, or step level). The expression expands to an empty string, so the uploaded artifact is named " rendered documentation" with a leading space.

Change

Define PACKAGE_NAME: mkl_random at the workflow level, matching the convention already used in conda-package.yml and conda-package-cf.yml. The artifact is now correctly named mkl_random rendered documentation.

The 'Save built docs as an artifact' step references ${{ env.PACKAGE_NAME }}
in the artifact name, but the variable was never defined in this workflow,
producing an artifact named ' rendered documentation' with a leading space.

Define PACKAGE_NAME at the workflow level, matching the convention used in
conda-package.yml.
@ndgrigorian
ndgrigorian merged commit bd61651 into master Aug 5, 2026
107 checks passed
@ndgrigorian
ndgrigorian deleted the fix-docs-artifact-name branch August 5, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants