Skip to content

ci-make improvements #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pflanze merged 3 commits into from
Aug 31, 2026
Merged

ci-make improvements #32

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9665764
ci-make: put all temp files into a single directory
pflanze Aug 24, 2026
7631c03
ci-make: show temp directory path, document intentional leak
pflanze Aug 31, 2026
8224809
ci-make: avoid treating input as test commands
pflanze Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions test/ci-make
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ usage() {
exit 1
}

if [ $# -eq 0 ] || [ "$1" = -h -o "$1" = --help ]; then
Comment thread
yusufraji marked this conversation as resolved.
if [ $# -eq 0 ] || [ "$1" = -h ] || [ "$1" = --help ]; then
usage
fi

Expand All @@ -26,21 +26,27 @@ run() {
fi
}

tmpfiles=()
tmpdir=$(mktemp -d)
# Leak the files in tmpdir on purpose so that they can be examined.
echo "ci-make writing to $tmpdir"

i=0
for target in "${targets[@]}"; do
tmp=$(mktemp)
tmpfiles+=("$tmp")
tmp="$tmpdir/$i"
i=$(( i + 1 ))
( run "$target" 2>&1 | test/target/debug/log-timestamp > "$tmp" ) &
done

for target in "${targets[@]}"; do
for _target in "${targets[@]}"; do
wait || true
done

exit_code=0

for tmp in "${tmpfiles[@]}"; do
i=0
for _target in "${targets[@]}"; do
tmp="$tmpdir/$i"
i=$(( i + 1 ))
echo "========================================================================================"
if tail -1 "$tmp" | grep -q ": Ok."; then
if [ "${CI_MAKE_VERBOSE-}" == 1 ]; then
Expand Down
Loading