Repository navigation
Fix-ups following the cj_check PR - #36
Merged
Merged
Conversation
With the new non-owning approach, the parser/AST does not need them anymore.
It is quite large, hence Clone is wasteful. Also, should universally never need Clone: either the type is Copy, then include it directly, or otherwise handle it by reference. - The `.map(|reference| &*reference)` is quite ugly. It is to turn the mutable reference into a shared one. (This is necessary because while an individual mutable reference is automatically cast to a shared one, after packing them up in the Vec no such conversion would happen anymore.) Not sure what to do about it.
Will this prove useful?
pflanze
force-pushed
the
cj_post_check_fixups
branch
from
September 5, 2026 15:22
a3b63b7 to
424303d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #30 left a few things open or sub-optimal, besides the anticipated BumpaloCow and ReborrowIn removal this also contains a few other small improvements.